Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Yihong Wang to collaborators #18824

Closed
wants to merge 1 commit into from
Closed

doc: add Yihong Wang to collaborators #18824

wants to merge 1 commit into from

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Feb 16, 2018

Refs: #18533

Signed-off-by: Yihong Wang yh.wang@ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@yhwang
doc: add Yihong Wang to collaborators
ee0dc4a 
Refs: nodejs#18533

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 16, 2018
mhdawson
mhdawson approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gibfahn
gibfahn approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Feb 17, 2018
yhwang added a commit to yhwang/node that referenced this pull request Feb 17, 2018
@yhwang
doc: add Yihong Wang to collaborators
6c9774f 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#18824
Refs: nodejs#18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@yhwang
Copy link
Member Author

yhwang commented Feb 17, 2018

Landed in 6c9774f and close the PR.

@yhwang yhwang closed this Feb 17, 2018
@yhwang yhwang deleted the add-yhwang-into-collaborator branch February 17, 2018 05:33
@Trott
Copy link
Member

Trott commented Feb 17, 2018

No CI?

@yhwang
Copy link
Member Author

yhwang commented Feb 17, 2018 •
edited
Loading

CI passed, I forgot to pasted the link, let me find it.

CI: https://ci.nodejs.org/job/node-test-commit/16316/

@Trott
Copy link
Member

Trott commented Feb 17, 2018

I forgot to pasted the link, let me find it.

Here it is: https://ci.nodejs.org/job/node-test-pull-request/13222/

@Trott
Copy link
Member

Trott commented Feb 17, 2018

Also: Welcome! :-D

@yhwang
Copy link
Member Author

yhwang commented Feb 17, 2018

Here it is: https://ci.nodejs.org/job/node-test-pull-request/13222/

Thanks @Trott . That's the first CI I kicked off and it failed on 2 sub jobs. Because this would be my first self-landed PR, I'd like to get a all-green CI. Then I kicked off another one and got a good result. :-p

The link I posted above is the second one.

@Trott
Copy link
Member

Trott commented Feb 17, 2018

Ah, so you were running full CIs. That explains why the onboarding process didn't finish in 90 minutes. :-D

For onboardings, it's usually enough to make sure the linter passes and maybe one other platform, and then we usually cancel the job. There's also the node-test-pull-request-lite task, which only runs LinuxOne and the linter. But those things probably aren't documented in the onboarding script, so that's probably why this happened. It's all coming together for me!

@yhwang
Copy link
Member Author

yhwang commented Feb 17, 2018

then we usually cancel the job. There's also the node-test-pull-request-lite task, which only runs LinuxOne and the linter. But those things probably aren't documented in the onboarding script, so that's probably why this happened. It's all coming together for me!

Oops.. Good to know that. Yes, I ran a full CI. Unfortunately, I don't have second chance to do that again. For the onboarding CI stuff, no, it's not in the onboarding script. Or maybe we can have a special CI to run doc change only PR. I also ran make -j8 test locally. It took another 20 minutes.

@joyeecheung joyeecheung mentioned this pull request Feb 17, 2018
Closed
@addaleax
Copy link
Member

Fwiw, when I’m onboarding people I usually let them kick off CI on an unrelated PR (that really needs it) first, then optionally too for the onboarding PR itself.

Or maybe we can have a special CI to run doc change only PR.

That’s more or less what we use the node-test-pull-request-lite job for that @Trott referred to, I think.

MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@yhwang @MylesBorins
doc: add Yihong Wang to collaborators
e071177 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #18824
Refs: #18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@yhwang @MylesBorins
doc: add Yihong Wang to collaborators
d1ff8fa 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #18824
Refs: #18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@yhwang @MylesBorins
doc: add Yihong Wang to collaborators
1bff0aa 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #18824
Refs: #18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@yhwang @MayaLekova
doc: add Yihong Wang to collaborators
0badb94 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#18824
Refs: nodejs#18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@yhwang @MylesBorins
doc: add Yihong Wang to collaborators
9ddb967 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #18824
Refs: #18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@yhwang @MylesBorins
doc: add Yihong Wang to collaborators
94cb344 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #18824
Refs: #18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@yhwang @MylesBorins
doc: add Yihong Wang to collaborators
47c9f45 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #18824
Refs: #18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@yhwang @MylesBorins
doc: add Yihong Wang to collaborators
2cbeea0 
Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #18824
Refs: #18533
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.