Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: switch to Number.isNaN #18744

Closed
wants to merge 2 commits into from
Closed

lib: switch to Number.isNaN #18744

wants to merge 2 commits into from

Commits on Feb 14, 2018

  1. buffer: remove obsolete NaN check 

    These two NaN entries are not necessary and we can safely remove them.
    @BridgeAR
    BridgeAR committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    7d42edc View commit details
    Browse the repository at this point in the history

  2. lib: switch to Number.isNaN 

    Number.isNaN is now as fast as `val !== val`. Switch to the more
readable version. Also switch all `isNaN` to `Number.isNaN`.
    @BridgeAR
    BridgeAR committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    ae2fd64 View commit details
    Browse the repository at this point in the history