Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add process.debugPort to doc/api/process.md #18716

Closed
wants to merge 4 commits into from
Closed

doc: add process.debugPort to doc/api/process.md #18716

wants to merge 4 commits into from

Conversation

flickz
Copy link
Contributor

@flickz flickz commented Feb 11, 2018

Ref: #18639

Added process.debugPort to process api doc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Feb 11, 2018
cjihrig
cjihrig approved these changes Feb 11, 2018
View reviewed changes
doc/api/process.md Outdated

A port number for the debugger to listen to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrase as "The port used by Node's debugger when it is enabled." or something similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

BridgeAR
BridgeAR reviewed Feb 12, 2018
View reviewed changes
doc/api/process.md Outdated

The port used by Node's debugger when enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually called Node.js so it should be called Node.js's.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 13, 2018
@targos
Copy link
Member

targos commented Feb 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/172/

BridgeAR
BridgeAR reviewed Feb 17, 2018
View reviewed changes
doc/api/process.md Outdated
The port used by Node.js's debugger when enabled.

```js
process.debugPort = 5858;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter complains about the indentation. Please do not use any spaces here :-)

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2018
@flickz
Copy link
Contributor Author

flickz commented Feb 19, 2018

@BridgeAR Resolved

@mmarchini
Copy link
Contributor

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite/195/

@mmarchini
Copy link
Contributor

mmarchini commented Feb 26, 2018 •
edited
Loading

Landed in 65ca369 😄

@mmarchini mmarchini closed this Feb 26, 2018
mmarchini pushed a commit that referenced this pull request Feb 26, 2018
@flickz
doc: add process.debugPort to doc/api/process.md
65ca369 
Fixes: #18639

PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit to addaleax/node that referenced this pull request Feb 26, 2018
@flickz @addaleax
doc: add process.debugPort to doc/api/process.md
b5ecc45 
Fixes: nodejs#18639

PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@flickz @addaleax
doc: add process.debugPort to doc/api/process.md
b456e31 
Fixes: #18639

PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleax addaleax mentioned this pull request Feb 27, 2018
Closed
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@flickz @MayaLekova
doc: add process.debugPort to doc/api/process.md
a3f2e94 
Fixes: nodejs#18639

PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@flickz @jasnell
doc: add process.debugPort to doc/api/process.md
88adf76 
Fixes: nodejs#18639

PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@flickz @MylesBorins
doc: add process.debugPort to doc/api/process.md
dbc5bed 
Fixes: #18639

Backport-PR-URL: #22380
PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@jasnell jasnell jasnell approved these changes

@daynin daynin daynin approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@mmarchini mmarchini mmarchini approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.