Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify constructor URLSearchParams. Remove needless check null #18700

Closed
wants to merge 1 commit into from
Closed

Simplify constructor URLSearchParams. Remove needless check null #18700

wants to merge 1 commit into from

Conversation

Connormiha
Copy link
Contributor

@Connormiha Connormiha commented Feb 10, 2018 •
edited
Loading

Remove needless check init !== null. init can't be null because we check it in previous if

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 10, 2018
@devsnek
Copy link
Member

devsnek commented Feb 10, 2018 •
edited
Loading

typeof null is actually object so this would allow null to be passed

edit: hehe didn't read the above if statement 👍

@BridgeAR
Copy link
Member

Closing due to the mentioned comment. @Connormiha thanks a lot for your contribution anyway!

@BridgeAR BridgeAR closed this Feb 10, 2018
@devsnek
Copy link
Member

devsnek commented Feb 10, 2018 •
edited
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/13081/

@BridgeAR it seems you caught github-doesnt-always-update-the-page-itus ❤️

@devsnek devsnek reopened this Feb 10, 2018
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 10, 2018
@devsnek
Copy link
Member

devsnek commented Feb 11, 2018

landed in 316846b

@devsnek devsnek closed this Feb 11, 2018
devsnek pushed a commit that referenced this pull request Feb 11, 2018
@Connormiha @devsnek
url: simplify constructor URLSearchParams. Remove needless check null
316846b 
PR-URL: #18700
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha @MylesBorins
url: simplify constructor URLSearchParams. Remove needless check null
f1ff107 
PR-URL: #18700
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha @MylesBorins
url: simplify constructor URLSearchParams. Remove needless check null
299a013 
PR-URL: #18700
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha @MylesBorins
url: simplify constructor URLSearchParams. Remove needless check null
cf845d4 
PR-URL: #18700
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha @MylesBorins
url: simplify constructor URLSearchParams. Remove needless check null
1767ef0 
PR-URL: #18700
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Connormiha @MayaLekova
url: simplify constructor URLSearchParams. Remove needless check null
4cecbcf 
PR-URL: nodejs#18700
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Connormiha @devsnek @BridgeAR @lpinca @TimothyGu @cjihrig @MylesBorins @nodejs-github-bot