Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix prof polyfill readline #18641

Closed
wants to merge 6 commits into from
Closed

tools: fix prof polyfill readline #18641

wants to merge 6 commits into from

Commits on Feb 11, 2018

  1. tools: fix prof polyfill readline 

    `node --prof foo.js` may not print the full profile log file,
the last line will broken like `tick,` and not more blank line.
`readline`will stuck in infinite loop, add `bytes === 0`
will fix it.
    @killagu
    killagu committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    33f4a51 View commit details
    Browse the repository at this point in the history

  2. test: add common.isSymbolAvailable

    @killagu
    killagu committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    45730d5 View commit details
    Browse the repository at this point in the history

  3. fix: fix code style

    @killagu
    killagu committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    2610183 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. mv common.isSymbolAvailable -> common.isCPPSymbolsNotMapped

    @killagu
    killagu committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    05b0391 View commit details
    Browse the repository at this point in the history

  2. fix c++ -> C++

    @killagu
    killagu committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    3684bc0 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. fix code style 

    fix warn message
fix comment style
    @killagu
    killagu committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    a43951e View commit details
    Browse the repository at this point in the history