Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http2-session-unref #18589

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-http2-session-unref #18589

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary.

Fixes: #18587

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@apapirovski
test: fix flaky test-http2-session-unref
9124af6 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 5, 2018
@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12958/

mhdawson
mhdawson approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe a stress run would be good as well ?

@apapirovski
Copy link
Member Author

Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1775/ (OS X as it's a good mix of building fast enough and being prone to being flaky due to being a slower box, compared to something like raspberry PI)

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 6, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 7, 2018

Landed in b8f7f84

@BridgeAR BridgeAR closed this Feb 7, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 7, 2018
@apapirovski @BridgeAR
test: fix flaky test-http2-session-unref
b8f7f84 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: nodejs#18589
Fixes: nodejs#18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@apapirovski apapirovski deleted the fix-flaky-test-http2-session-unref branch February 7, 2018 16:50
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@apapirovski @MylesBorins
test: fix flaky test-http2-session-unref
298ee05 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: #18589
Fixes: #18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@apapirovski @MylesBorins
test: fix flaky test-http2-session-unref
102dac8 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: #18589
Fixes: #18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@apapirovski @MylesBorins
test: fix flaky test-http2-session-unref
30a233c 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: #18589
Fixes: #18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@apapirovski @MayaLekova
test: fix flaky test-http2-session-unref
3ed17c5 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: nodejs#18589
Fixes: nodejs#18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intermittent? parallel/test-http2-session-unref failure on sharedlibs debug
8 participants
@apapirovski @BridgeAR @jasnell @cjihrig @hiroppy @mhdawson @gibfahn @nodejs-github-bot