buffer: coerce offset to integer #18215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset was formerly coerced to a integer and this reimplements that. Fixes nodejs#18208
nodejs-github-bot
added
the
buffer
bnoordhuis
approved these changes
Jan 17, 2018
jasnell
reviewed
Jan 17, 2018
| @@ -1272,25 +1272,29 @@ function toFloat(x) { | |||
|
|
|||
|
|
|||
| Buffer.prototype.readDoubleBE = function(offset, noAssert) { | |||
| offset = offset >>> 0; | |||
There was a problem hiding this comment.
hmm... I'd almost prefer to make this an error rather than coerce. If someone just happens to pass in 4294967296 as the offset, they're going to get unexpected results otherwise.
There was a problem hiding this comment.
I prefer that as well but all other functions right now coerce the numbers to uint32. I will open a separate PR to change that for all functions.
richardlau
approved these changes
Jan 18, 2018
cjihrig
approved these changes
Jan 18, 2018
BridgeAR
added
the
author ready
tniessen
approved these changes
Jan 20, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 24, 2018
The offset was formerly coerced to a integer and this reimplements that. PR-URL: nodejs#18215 Fixes: nodejs#18208 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in 7a23fc0 |
|
@BridgeAR There seems to be still no tests for e.g. |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
The offset was formerly coerced to a integer and this reimplements that. PR-URL: #18215 Fixes: #18208 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
The offset was formerly coerced to a integer and this reimplements that. PR-URL: #18215 Fixes: #18208 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
removed
the
author ready
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The offset was formerly coerced to a integer and this reimplements that. PR-URL: nodejs#18215 Fixes: nodejs#18208 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
@BridgeAR this doesn't land cleanly on |
|
@BridgeAR ... ping ... can you open a backport PR for 8.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset was formerly coerced to a integer and this reimplements
that.
Fixes #18208
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
buffer