tty: fix console printing on Windows #18214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: nodejs#18189 Refs: nodejs#18019
|
#18189 seems to be fixed with this PR for me. |
jasnell
approved these changes
Jan 18, 2018
cjihrig
approved these changes
Jan 18, 2018
addaleax
added
the
author ready
|
Landed in ea7400c |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 19, 2018
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: nodejs#18189 Refs: nodejs#18019 PR-URL: nodejs#18214 Fixes: nodejs#18189 Refs: nodejs#18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Setting this as don't land for v9.x as the original didn't land |
addaleax
added a commit
that referenced
this pull request
Feb 26, 2018
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 26, 2018
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
addaleax
removed
the
author ready
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: nodejs#18189 Refs: nodejs#18019 PR-URL: nodejs#18214 Fixes: nodejs#18189 Refs: nodejs#18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
added
the
baking-for-lts
|
nb: should be backported with #18019 |
MylesBorins
added
land-on-v8.x
and removed
baking-for-lts
|
Backported along with #18019 |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent.
This partially reverts 8b751f7.
Fixes: #18189
Refs: #18019
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
/cc @vsemozhetbyt