Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update sample output for process.versions #18167

Closed
wants to merge 2 commits into from
Closed

doc: update sample output for process.versions #18167

wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

Update so that it includes some of the more
recent additions

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Jan 15, 2018
@tniessen
Copy link
Member

The commit message should probably say doc: update sample output for process.versions (not process.env).

cjihrig
cjihrig approved these changes Jan 15, 2018
View reviewed changes
doc/api/process.md Outdated
unicode: '8.0',
cldr: '29.0',
{ http_parser: '2.7.0',
node: '10.0.0-pre',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor nit, but I suggest using an actual release version to avoid any confusion from the -pre.

@mhdawson mhdawson changed the title doc: update sample output for process.env doc: update sample output for process.versions Jan 15, 2018
@mhdawson
doc: update sample output for process.versions
ac1b06d 
Update so that it includes some of the more
recent additions
@mhdawson
Copy link
Member Author

Pushed commit to address comments.

@joyeecheung
Copy link
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/95/

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2018
@tniessen
Copy link
Member

Landed in 5aa0f3e.

@tniessen tniessen closed this Jan 17, 2018
tniessen pushed a commit that referenced this pull request Jan 17, 2018
@mhdawson @tniessen
doc: update sample output for process.versions
5aa0f3e 
Update so that it includes some of the more recent additions.

PR-URL: #18167
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@mhdawson @evanlucas
doc: update sample output for process.versions
1d74c33 
Update so that it includes some of the more recent additions.

PR-URL: #18167
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@mhdawson @MylesBorins
doc: update sample output for process.versions
299482c 
Update so that it includes some of the more recent additions.

PR-URL: #18167
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@mhdawson @MayaLekova
doc: update sample output for process.versions
c3e7596 
Update so that it includes some of the more recent additions.

PR-URL: nodejs#18167
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@mhdawson mhdawson deleted the process-example branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@JungMinu JungMinu JungMinu approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.