fs: migrate ASYNC_CALL to AsyncCall #18144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Jan 14, 2018
joyeecheung
commented
Jan 14, 2018
| @@ -1030,26 +1031,6 @@ static void WriteString(const FunctionCallbackInfo<Value>& args) { | |||
| SYNC_CALL(write, nullptr, fd, &uvbuf, 1, pos) | |||
| return args.GetReturnValue().Set(SYNC_RESULT); | |||
| } | |||
|
|
|||
| FSReqWrap* req_wrap = | |||
| FSReqWrap::New(env, req.As<Object>(), "write", buf, UTF8, ownership); | |||
There was a problem hiding this comment.
Just noticed that the ownership is lost below. I've fixed it locally but when writing a test for it it seems that fs.write does not work on external two-byte strings on master.
jasnell
approved these changes
Jan 14, 2018
|
There were some infra issues on linux one. Just in case, a new CI: https://ci.nodejs.org/job/node-test-pull-request/12540/ |
joyeecheung
added
the
author ready
|
Landed in eca73a2, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Jan 16, 2018
This patch migrates all the `ASYNC_CALL` macro in `node_file.cc` to the template counterpart AsyncCall. Also goes with a different style of wrapping the arguments so it's clearer to see what arguments are passed to which `uv_fs_*` functions. PR-URL: #18144 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung
added
dont-land-on-v4.x
and removed
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch migrates all the
ASYNC_CALLmacro in node_file.cc to the template counterpartAsyncCall. Also goes with a different style of wrapping the arguments so it's clearer to see what arguments are passed to whichuv_fs_*functions.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs