Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky inspector-stop-profile-after-done #18126

Closed
wants to merge 25 commits into from
Closed

test: fix flaky inspector-stop-profile-after-done #18126

wants to merge 25 commits into from

Commits on Mar 2, 2018

  1. wip: fix flaky inspector-stop-profile-after-done 

    In test/sequential/test-inspector-stop-profile-after-done.js, if
`Profile.start` is received after the debugger is waiting to disconnect,
then the process will not terminate.

Fixes: nodejs#16772
    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    7e6ce28 View commit details
    Browse the repository at this point in the history

  2. wip: throw rather than timeout on infinite loop

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    6eb2a64 View commit details
    Browse the repository at this point in the history

  3. assert-o-rama

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    fa0be69 View commit details
    Browse the repository at this point in the history

  4. reduce test to basically nothing

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    7f6e390 View commit details
    Browse the repository at this point in the history

  5. wip: add session

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    7435ae2 View commit details
    Browse the repository at this point in the history

  6. wip: add an await

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    beb87c3 View commit details
    Browse the repository at this point in the history

  7. add another await

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    f934fb1 View commit details
    Browse the repository at this point in the history

  8. a third await

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    b2c0fb2 View commit details
    Browse the repository at this point in the history

  9. wip: send four command

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    9838d7f View commit details
    Browse the repository at this point in the history

  10. wip: reduce messages to 1

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    20a565c View commit details
    Browse the repository at this point in the history

  11. wip: 2 sends

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    99f7d51 View commit details
    Browse the repository at this point in the history

  12. wip: 3 sends

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    02fcc81 View commit details
    Browse the repository at this point in the history

  13. wip: is it better if we await the whole debugger-attach thing?

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    4c6c788 View commit details
    Browse the repository at this point in the history

  14. all four sends

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    4d3f4c8 View commit details
    Browse the repository at this point in the history

  15. wip: 3 sends but still waiting for debugger disconnect message

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    c57df84 View commit details
    Browse the repository at this point in the history

  16. try moving Profiler.start

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    be6a7f1 View commit details
    Browse the repository at this point in the history

  17. see if moving Profiler.start after program exits still has flaky resu… 

    …lts or not
    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    053d19e View commit details
    Browse the repository at this point in the history

  18. add an await

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    63ad338 View commit details
    Browse the repository at this point in the history

  19. no reason to think this will go any better but why not?

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    aff6d01 View commit details
    Browse the repository at this point in the history

  20. try writing to the process to let it know when to end

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    37748aa View commit details
    Browse the repository at this point in the history

  21. remove profiler to see if that fixes it

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    9b9abc6 View commit details
    Browse the repository at this point in the history

  22. try longer times

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    7143464 View commit details
    Browse the repository at this point in the history

  23. doubling all the times: makes it worse or better or neither?

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    818e16f View commit details
    Browse the repository at this point in the history

  24. increase times some more as it seems to enhance stability

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    ecd18cf View commit details
    Browse the repository at this point in the history

  25. increase timeouts

    @Trott
    Trott committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    e259d26 View commit details
    Browse the repository at this point in the history