test: simplify loadDHParam in TLS test #18103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Jan 11, 2018
jasnell
approved these changes
Jan 11, 2018
cjihrig
approved these changes
Jan 11, 2018
lpinca
approved these changes
Jan 11, 2018
| let path = fixtures.fixturesDir; | ||
| if (n !== 'error') path += '/keys'; | ||
| return fs.readFileSync(`${path}/dh${n}.pem`); | ||
| return fixtures.readKey(`dh${n}.pem`); |
There was a problem hiding this comment.
Nit: it can also be inlined at this point. Ignore this comment if it is more readable in this way.
There was a problem hiding this comment.
I considered it but then decided to keep it this way as test-tls-dhe.js declares the same function with additional logic to handle the error case. I can still remove it if you would like.
There was a problem hiding this comment.
test-tls-dhe.js, ok it makes sense, it's really a nuance.
|
Landed in eb68a06. |
tniessen
added a commit
that referenced
this pull request
Jan 17, 2018
PR-URL: #18103 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18103 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18103 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18103 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither of these tests seems to use the
errorvalue.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test