doc: simplify sentences that use "considered" #18095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change many instances of "x is considered to be y" to "x is y".
gireeshpunathil
approved these changes
Jan 11, 2018
danbev
approved these changes
Jan 11, 2018
cjihrig
approved these changes
Jan 11, 2018
richardlau
approved these changes
Jan 11, 2018
jasnell
approved these changes
Jan 11, 2018
lpinca
approved these changes
Jan 11, 2018
| @@ -622,7 +622,7 @@ Once a socket is assigned to this request and is connected | |||
| added: v0.5.9 | |||
| --> | |||
|
|
|||
| * `timeout` {number} Milliseconds before a request is considered to be timed out. | |||
| * `timeout` {number} Milliseconds before a request times out. | |||
There was a problem hiding this comment.
Unrelated but I think this description is a bit misleading. This timeout expires only after x millisecond of inactivity on the socket. It's possible that a data chunk resets the timeout right before it expires without completing the request.
I'll open a separate PR if I remember :)
There was a problem hiding this comment.
@lpinca Perhaps you or I can add a squash-able commit here to change it to Milliseconds of inactivity before a request times out.?
|
Landed in c6bee70. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 18, 2018
Change many instances of "x is considered to be y" to "x is y". PR-URL: nodejs#18095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Change many instances of "x is considered to be y" to "x is y". PR-URL: #18095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Change many instances of "x is considered to be y" to "x is y". PR-URL: #18095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Change many instances of "x is considered to be y" to "x is y". PR-URL: #18095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Change many instances of "x is considered to be y" to "x is y". PR-URL: nodejs#18095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change many instances of "x is considered to be y" to "x is y".
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc