Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add JSStreamWrap benchmark #17983

Closed
wants to merge 1 commit into from
Closed

benchmark: add JSStreamWrap benchmark #17983

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jan 4, 2018

This is made to mirror the connection-bound net benchmarks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark/net

@addaleax
benchmark: add JSStreamWrap benchmark
4fcc4f8 
This is made to mirror the connection-bound net benchmarks.
@addaleax addaleax added benchmark Issues and PRs related to the benchmark subsystem. net Issues and PRs related to the net subsystem. labels Jan 4, 2018
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. net Issues and PRs related to the net subsystem. labels Jan 4, 2018
@addaleax addaleax mentioned this pull request Jan 4, 2018
Closed
2 tasks
mcollina
mcollina approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Jan 10, 2018

CI Lint run: https://ci.nodejs.org/job/node-test-linter/15045/

jasnell pushed a commit that referenced this pull request Jan 10, 2018
@addaleax @jasnell
benchmark: add JSStreamWrap benchmark
7a18f09 
This is made to mirror the connection-bound net benchmarks.

PR-URL: #17983
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 10, 2018

Landed in 7a18f09

@jasnell jasnell closed this Jan 10, 2018
evanlucas pushed a commit that referenced this pull request Jan 22, 2018
@addaleax @evanlucas
benchmark: add JSStreamWrap benchmark
8f9060c 
This is made to mirror the connection-bound net benchmarks.

PR-URL: #17983
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@addaleax @evanlucas
benchmark: add JSStreamWrap benchmark
a4ba791 
This is made to mirror the connection-bound net benchmarks.

PR-URL: #17983
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
@MylesBorins
Copy link
Contributor

Does this make sense for v6.x or v8.x?

MylesBorins pushed a commit that referenced this pull request May 22, 2018
@addaleax @MylesBorins
benchmark: add JSStreamWrap benchmark
07e8195 
This is made to mirror the connection-bound net benchmarks.

PR-URL: #17983
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@addaleax @MylesBorins
benchmark: add JSStreamWrap benchmark
1cf0f61 
This is made to mirror the connection-bound net benchmarks.

PR-URL: #17983
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
benchmark: add JSStreamWrap benchmark
0a3ebb0 
This is made to mirror the connection-bound net benchmarks.

PR-URL: #17983
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @jasnell @MylesBorins @mcollina @Trott @lpinca @nodejs-github-bot