build: remove duplicate async-hooks and known_issues test runs #17912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `default` test suite in `test.py` includes `async-hooks` and `known_issues`. Our current setup results in those test suites being run twice during each CI run. Remove the duplication.
Trott
added
build
nodejs-github-bot
added
build
jasnell
approved these changes
Dec 29, 2017
lpinca
approved these changes
Dec 29, 2017
cjihrig
approved these changes
Dec 29, 2017
BridgeAR
approved these changes
Dec 29, 2017
|
CI is green but for some reason there was no Windows run and the node-test-commit job was hung after 12 hours. Re-running: https://ci.nodejs.org/job/node-test-commit/15133/ |
|
CI is all green (again) and a spot check reveals that both |
Trott
added
the
author ready
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 3, 2018
The `default` test suite in `test.py` includes `async-hooks` and `known_issues`. Our current setup results in those test suites being run twice during each CI run. Remove the duplication. PR-URL: nodejs#17912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in f05fb01 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
The `default` test suite in `test.py` includes `async-hooks` and `known_issues`. Our current setup results in those test suites being run twice during each CI run. Remove the duplication. PR-URL: #17912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
The `default` test suite in `test.py` includes `async-hooks` and `known_issues`. Our current setup results in those test suites being run twice during each CI run. Remove the duplication. PR-URL: #17912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
The `default` test suite in `test.py` includes `async-hooks` and `known_issues`. Our current setup results in those test suites being run twice during each CI run. Remove the duplication. PR-URL: #17912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
TimothyGu
removed
the
author ready
|
Should this be backported to LTS? |
I can go either way, honestly. I'm leaning towards "nah". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
defaulttest suite intest.pyincludesasync-hooksandknown_issues. Our current setup results in those test suites being runtwice during each CI run. Remove the duplication.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build test