Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: remove ERR_OUTOFMEMORY #17877

Closed
wants to merge 1 commit into from
Closed

Conversation

tniessen
Copy link
Member

The error code ERR_OUTOFMEMORY was added in e71e71b and is unused ever since 69e6c5a. Apart from not being used within node core, it is the only error code which does not use underscores to separate words (ERR_OUTOFMEMORY vs ERR_OUT_OF_RANGE).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Dec 27, 2017
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I am fine with this because http2 is still experimental. But we should never remove a error code from now on. Instead, we should deprecate it. The reason is that otherwise people who run into this error code in a older version can not find a proper explanation for it anymore. We night consider adding a specific area for out-dated codes.

@tniessen
Copy link
Member Author

@BridgeAR While this might generally be true, I don't think it matters in this particular case. The documentation for ERR_OUTOFMEMORY contains no information which is not already in the error message itself.

We night consider adding a specific area for out-dated codes.

+1 if that ever turns out to be necessary.

@tniessen
Copy link
Member Author

@tniessen
Copy link
Member Author

Landed in a82b1b7.

@tniessen tniessen closed this Dec 29, 2017
tniessen added a commit that referenced this pull request Dec 29, 2017
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor

This does not land cleanly on v9.x, could it be backported?

tniessen added a commit to tniessen/node that referenced this pull request Jan 11, 2018
PR-URL: nodejs#17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 17, 2018
Backport-PR-URL: #18099
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
PR-URL: nodejs#17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen
Copy link
Member Author

tniessen commented Mar 4, 2018

@MylesBorins #19117

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
Backport-PR-URL: #19117
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
Backport-PR-URL: #19117
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
Backport-PR-URL: #19117
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants