Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable array-callback-return ESLint rule #17858

Closed
wants to merge 3 commits into from
Closed

tools: enable array-callback-return ESLint rule #17858

wants to merge 3 commits into from

Commits on Dec 27, 2017

  1. readline: refactor filter() callback 

    Use construct that always returns a boolean for `filter()` callback.
    @Trott
    Trott committed Dec 27, 2017
    Configuration menu
    Copy the full SHA
    d018b7b View commit details
    Browse the repository at this point in the history

  2. test: replace map() with forEach() where appropriate 

    Two tests were using Array.prototype.map() without returning values in
the callback. In other words, they were using it where a `.forEach()`
was called for. Change to `.forEach()`.
    @Trott
    Trott committed Dec 27, 2017
    Configuration menu
    Copy the full SHA
    5817019 View commit details
    Browse the repository at this point in the history

  3. tools: enable array-callback-return ESLint rule 

    For array methods that depend on a callback (such as `.filter()` or
`.map()`), require a return value from the callback.
    @Trott
    Trott committed Dec 27, 2017
    Configuration menu
    Copy the full SHA
    22a5f05 View commit details
    Browse the repository at this point in the history