Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce scope of variable in common module #17830

Closed
wants to merge 1 commit into from
Closed

test: reduce scope of variable in common module #17830

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 22, 2017

arrayBufferViews is used by only one function so scope it to that
function (in the common module).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott
test: reduce scope of variable in common module
4512626 
arrayBufferViews is used by only one function so scope it to that
function (in the common module).
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 22, 2017
@Trott
Copy link
Member Author

Trott commented Dec 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12272/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 24, 2017
@Trott
Copy link
Member Author

Trott commented Dec 26, 2017

Landed in 03b8ac1

@Trott Trott closed this Dec 26, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 26, 2017
@Trott
test: reduce scope of variable in common module
03b8ac1 
arrayBufferViews is used by only one function so scope it to that
function (in the common module).

PR-URL: nodejs#17830
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott @MylesBorins
test: reduce scope of variable in common module
d58f1b7 
arrayBufferViews is used by only one function so scope it to that
function (in the common module).

PR-URL: #17830
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
test: reduce scope of variable in common module
ac6d0d6 
arrayBufferViews is used by only one function so scope it to that
function (in the common module).

PR-URL: #17830
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
test: reduce scope of variable in common module
8b666d6 
arrayBufferViews is used by only one function so scope it to that
function (in the common module).

PR-URL: #17830
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@Trott @gibfahn
test: reduce scope of variable in common module
efdf671 
arrayBufferViews is used by only one function so scope it to that
function (in the common module).

PR-URL: #17830
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@Trott @gibfahn
test: reduce scope of variable in common module
5485ad1 
arrayBufferViews is used by only one function so scope it to that
function (in the common module).

PR-URL: #17830
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the refactor-arraybuffer branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@maclover7 maclover7 maclover7 approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @lpinca @TimothyGu @maclover7 @vsemozhetbyt @addaleax @gibfahn @nodejs-github-bot