doc: add change info for async_hooks.executionAsyncId() #17813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0.
nodejs-github-bot
added
async_hooks
I think what you have currently is clear, so +1 on that. |
cjihrig
approved these changes
Dec 27, 2017
jasnell
approved these changes
Dec 28, 2017
|
cc @nodejs/diagnostics |
|
LGTM, Although I think I renamed more than just this. |
ofrobots
approved these changes
Jan 13, 2018
joyeecheung
added
the
author ready
|
Landed in dadf282 |
addaleax
pushed a commit
that referenced
this pull request
Jan 18, 2018
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: #17813 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: #17813 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: #17813 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: #17813 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: nodejs#17813 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add meta information to async_hooks documentation informing that
executionAsyncId was renamed from currentId at Node.js 8.2.0.
Not sure if maybe it'd be more correct to show it as "added" rather than "changed" at 8.2.0. Thoughts, @nodejs/documentation ?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc