test: do not open fixture files for writing #17808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-fs-fsync makes a copy of a fixture file, but then doesn't do anything with it and instead operates on the original fixture file. This appears to be in error, and this change fixes that.
maclover7
approved these changes
Dec 21, 2017
cjihrig
approved these changes
Dec 21, 2017
richardlau
approved these changes
Dec 22, 2017
BridgeAR
approved these changes
Dec 22, 2017
gireeshpunathil
approved these changes
Dec 22, 2017
jasnell
approved these changes
Dec 22, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 22, 2017
test-fs-fsync makes a copy of a fixture file, but then doesn't do anything with it and instead operates on the original fixture file. This appears to be in error, and this change fixes that. PR-URL: nodejs#17808 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 92fc14a |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
test-fs-fsync makes a copy of a fixture file, but then doesn't do anything with it and instead operates on the original fixture file. This appears to be in error, and this change fixes that. PR-URL: #17808 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
test-fs-fsync makes a copy of a fixture file, but then doesn't do anything with it and instead operates on the original fixture file. This appears to be in error, and this change fixes that. PR-URL: #17808 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
test-fs-fsync makes a copy of a fixture file, but then doesn't do anything with it and instead operates on the original fixture file. This appears to be in error, and this change fixes that. PR-URL: #17808 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
test-fs-fsync makes a copy of a fixture file, but then doesn't do anything with it and instead operates on the original fixture file. This appears to be in error, and this change fixes that. PR-URL: #17808 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
test-fs-fsync makes a copy of a fixture file, but then doesn't do anything with it and instead operates on the original fixture file. This appears to be in error, and this change fixes that. PR-URL: #17808 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-fs-fsync makes a copy of a fixture file, but then doesn't do
anything with it and instead operates on the original fixture file. This
appears to be in error, and this change fixes that.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test