Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add space to class string of iterator objects and updated tests accordingly #17558

Closed
wants to merge 5 commits into from
Closed

lib: add space to class string of iterator objects and updated tests accordingly #17558

wants to merge 5 commits into from

Conversation

haejinjo
Copy link

@haejinjo haejinjo commented Dec 9, 2017 •
edited
Loading

Inserted a space in the string descriptor for URLSearchParamsIterator
in the URL parser API so that it became URLSearchParams Iterator
according to recent changes in the standards.

Sorry I didn't realize my commit message was bad until I read
the guidelines.

Fixes: #17540

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Dec 9, 2017
@Trott
Copy link
Member

Trott commented Dec 9, 2017

Hello, @haejinjo! Welcome, and thanks for this PR!

It looks like you checked in three files that are backup files from your editor. These are the files with names that end with ~. Can you please remove those files from your branch?

@prohaejin
removed three backup files from my editor
bbcc2f4 
Using the command find -name "*~" I identified which files in
my branch were unnecessary (denoted by the ~ ending in their
filename) and removed them from their respective directories
in test and lib.
@prohaejin
Merge branch 'master' of https://github.com/haejinjo/node
867b4e9
@prohaejin
removed three backup files from my editor
f607358 
Using the command find -name "*~" I identified which files in
my branch were unnecessary (denoted by the ~ ending in their
filename) and removed them from their respective directories
in test and lib.
@haejinjo
Copy link
Author

haejinjo commented Dec 9, 2017

Thank you @Trott! I didn't know it was bad to have backup files. Is it just to keep the directory clean and orderly, or do they have more serious risks than is immediately apparent? Anyway, hope everything checks out now! Let me know.

@devsnek
Copy link
Member

devsnek commented Dec 9, 2017 •
edited
Loading

i think he meant that having backups is good, but they don't really belong in the repo 😄

TimothyGu
TimothyGu approved these changes Dec 10, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@apapirovski
Copy link
Member

apapirovski commented Dec 12, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/12050/

@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2017
@apapirovski
Copy link
Member

Hi @haejinjo — could you try to get rid of the merge commit in here and rebase without it? Otherwise we can't run the CI and land this.

@apapirovski apapirovski removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2017
@maclover7 maclover7 added the wip Issues and PRs that are still a work in progress. label Dec 12, 2017
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Dec 13, 2017
@addaleax
Copy link
Member

CI (without rebasing): https://ci.nodejs.org/job/node-test-commit/14785/

It should be fine if whoever lands this takes care of rebasing the merge commit out

addaleax pushed a commit to addaleax/node that referenced this pull request Dec 13, 2017
@prohaejin @addaleax
url: added space to class string of iterator objects
71c32b6 
PR-URL: nodejs#17558
Fixes: nodejs#17540
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

Landed in 486290b 🎉 Thanks for the PR!

@addaleax addaleax closed this Dec 13, 2017
addaleax pushed a commit that referenced this pull request Dec 13, 2017
@prohaejin @addaleax
url: added space to class string of iterator objects
486290b 
PR-URL: #17558
Fixes: #17540
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
@TimothyGu TimothyGu mentioned this pull request Dec 13, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@prohaejin @MylesBorins
url: added space to class string of iterator objects
28ef3de 
PR-URL: #17558
Fixes: #17540
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@prohaejin @MylesBorins
url: added space to class string of iterator objects
e0a780b 
PR-URL: #17558
Fixes: #17540
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@prohaejin @MylesBorins
url: added space to class string of iterator objects
0502e60 
PR-URL: #17558
Fixes: #17540
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@prohaejin @rvagg
url: added space to class string of iterator objects
654ce4b 
PR-URL: #17558
Fixes: #17540
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell jasnell approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync WHATWG URL parser with upstream standards