Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused include node_crypto_clienthello #17546

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Dec 8, 2017

This commit removes the include of node.h which does not seem to be
used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

This commit removes the include of node.h which does not seem to be
used.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Dec 8, 2017
@danbev
Copy link
Contributor Author

danbev commented Dec 8, 2017

@danbev
Copy link
Contributor Author

danbev commented Dec 8, 2017

@danbev
Copy link
Contributor Author

danbev commented Dec 11, 2017

Landed in 7bb2cc4.

@danbev danbev closed this Dec 11, 2017
@danbev danbev deleted the remove-unused-include-node_crypto_clienthello.h branch December 11, 2017 12:05
danbev added a commit that referenced this pull request Dec 11, 2017
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants