Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky async-hooks/test-graph.signal #17509

Closed
wants to merge 1 commit into from
Closed

test: fix flaky async-hooks/test-graph.signal #17509

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 6, 2017

Make sure event loop remains open long enough for signal to be received.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test async-hooks

@Trott Trott added async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. wip Issues and PRs that are still a work in progress. test Issues and PRs related to the tests. labels Dec 6, 2017
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Dec 6, 2017
@Trott
test: fix flaky async-hooks/test-graph.signal
820aeb4 
Make sure event loop remains open long enough for signal to be received.

Fixes: nodejs#14568
@Trott
Copy link
Member Author

Trott commented Dec 6, 2017 •
edited
Loading

Stress test on master showing failures (although only 2 failures in 19200 runs):
https://ci.nodejs.org/job/node-stress-single-test/1559/nodes=centos7-64/console

Stress test with this PR: https://ci.nodejs.org/job/node-stress-single-test/1561/nodes=centos7-64/console

@Trott
Copy link
Member Author

Trott commented Dec 6, 2017

Stress test came back green! Removing the in progress label.

@Trott Trott mentioned this pull request Dec 6, 2017
Closed
@Trott Trott removed the wip Issues and PRs that are still a work in progress. label Dec 6, 2017
@Trott
Copy link
Member Author

Trott commented Dec 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11925/

@Trott
Copy link
Member Author

Trott commented Dec 7, 2017

Lint error appears to be caused by #17460 and unrelated to this.

@Trott
Copy link
Member Author

Trott commented Dec 7, 2017

Running CI again now that linter has been unbroken. Unrelated build failure on macOS too, so canceled the whole thing and starting again...

CI: https://ci.nodejs.org/job/node-test-pull-request/11928/

@Trott
Copy link
Member Author

Trott commented Dec 7, 2017

CI failures are two known unrelated flaky tests and a build failure.

Re-running the build failure: https://ci.nodejs.org/job/node-test-commit-linuxone/10970/

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2017
@Trott
test: fix flaky async-hooks/test-graph.signal
8997026 
Make sure event loop remains open long enough for signal to be received.

PR-URL: nodejs#17509
Fixes: nodejs#14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@Trott
Copy link
Member Author

Trott commented Dec 8, 2017

Landed in 8997026

@Trott Trott closed this Dec 8, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
test: fix flaky async-hooks/test-graph.signal
da5dd45 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
test: fix flaky async-hooks/test-graph.signal
0f40069 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
test: fix flaky async-hooks/test-graph.signal
f5a1e6c 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Trott @gibfahn
test: fix flaky async-hooks/test-graph.signal
b016cbb 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: fix flaky async-hooks/test-graph.signal
683daea 
Make sure event loop remains open long enough for signal to be received.

PR-URL: #17509
Fixes: #14568
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@Trott Trott deleted the fix-flake branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@evanlucas evanlucas evanlucas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @refack @evanlucas @cjihrig @richardlau @gibfahn @nodejs-github-bot