Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace assert.throws with common.expectsError #17494

Closed
wants to merge 1 commit into from
Closed

test: replace assert.throws with common.expectsError #17494

wants to merge 1 commit into from

Conversation

mithunsasidharan
Copy link
Contributor

@mithunsasidharan mithunsasidharan commented Dec 6, 2017 •
edited
Loading

Refactored tests to replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in following test files :

  • test/parallel/test-dgram-createSocket-type.js
  • test/parallel/test-dgram-custom-lookup.js
  • test/parallel/test-dgram-membership.js
  • test/parallel/test-dgram-multicast-setTTL.js
  • test/parallel/test-dgram-sendto.js
  • test/parallel/test-dgram-setTTL.js
  • test/parallel/test-dgram-socket-buffer-size.js
  • test/parallel/test-dns-lookup.js
  • test/parallel/test-dns-regress-7070.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 6, 2017
apapirovski
apapirovski approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but commit message should ideally be adjusted to <= 50 chars.

@mithunsasidharan mithunsasidharan changed the title test: refactored to replace assert.throws with common.expectsError test: replace assert.throws with common.expectsError Dec 6, 2017
@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Thanks.. updated both PR and commit message. Thanks !

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11930/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
@mithunsasidharan mithunsasidharan mentioned this pull request Dec 8, 2017
Closed
3 tasks
@apapirovski
Copy link
Member

Lone failure appears unrelated, landing now.

@apapirovski
Copy link
Member

Landed in 20a8e83

@apapirovski apapirovski closed this Dec 8, 2017
apapirovski pushed a commit that referenced this pull request Dec 8, 2017
@mithunsasidharan @apapirovski
test: replace assert.throws w/ common.expectsError
20a8e83 
PR-URL: #17494
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: replace assert.throws w/ common.expectsError
7f01082 
PR-URL: #17494
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: replace assert.throws w/ common.expectsError
c2ff36e 
PR-URL: #17494
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mithunsasidharan @maclover7 @apapirovski @jasnell @lpinca @cjihrig @BridgeAR @addaleax @gibfahn @nodejs-github-bot