Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use common.expectsError in tests #17484

Closed
wants to merge 1 commit into from
Closed

test: Use common.expectsError in tests #17484

wants to merge 1 commit into from

Conversation

mithunsasidharan
Copy link
Contributor

@mithunsasidharan mithunsasidharan commented Dec 6, 2017 •
edited
Loading

Refactored tests to replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in following test files :

  • test/parallel/test-buffer-slow.js
  • test/parallel/test-buffer-tostring-range.js
  • test/parallel/test-child-process-send-type-error.js
  • test/parallel/test-child-process-spawnsync-kill-signal.js
  • test/parallel/test-child-process-stdio.js
  • test/parallel/test-child-process-validate-stdio.js
  • test/parallel/test-common.js
  • test/parallel/test-console-instance.js
  • test/parallel/test-dgram-bind.js
  • test/parallel/test-dgram-create-socket-handle.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 6, 2017
@apapirovski
Copy link
Member

Hi @mithunsasidharan — thank you for contributing. Could you use the checklist in your PR to indicate which changes have happened or whether you've run the tests locally? It seems like all your PRs have the checkboxes completely unchecked. In general, it's helpful to at least run make test -j4 locally.

@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Sorry for missing out on that. I usually run all test for any changes I make make -j4 test including changes in this PR. I'll be creating few more PRs for the same change in left over files. Let me know if you need any more info from my side. Thanks a lot.

apapirovski
apapirovski approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating the checklist 👍

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11926/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
@mithunsasidharan mithunsasidharan mentioned this pull request Dec 8, 2017
Closed
3 tasks
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11985/

CI was a little wonky the last time, just running again to be safe.

@apapirovski
Copy link
Member

Landed in d8c896c

@apapirovski apapirovski closed this Dec 8, 2017
apapirovski pushed a commit that referenced this pull request Dec 8, 2017
@mithunsasidharan @apapirovski
test: use common.expectsError in tests
d8c896c 
PR-URL: #17484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: use common.expectsError in tests
6ec7f9c 
PR-URL: #17484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: use common.expectsError in tests
28b2d8a 
PR-URL: #17484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mithunsasidharan @apapirovski @maclover7 @jasnell @lpinca @cjihrig @BridgeAR @addaleax @gibfahn @nodejs-github-bot