Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace assert.throws in tests with common.expectsError #17483

Closed
wants to merge 1 commit into from
Closed

refactor: replace assert.throws in tests with common.expectsError #17483

wants to merge 1 commit into from

Conversation

mithunsasidharan
Copy link
Contributor

@mithunsasidharan mithunsasidharan commented Dec 6, 2017 •
edited
Loading

Refactored tests to replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in following test files :

  • test/parallel/test-async-hooks-asyncresource-constructor.js
  • test/parallel/test-async-wrap-constructor.js
  • test/parallel/test-buffer-alloc.js
  • test/parallel/test-buffer-arraybuffer.js
  • test/parallel/test-buffer-compare-offset.js
  • test/parallel/test-buffer-compare.js
  • test/parallel/test-buffer-concat.js
  • test/parallel/test-buffer-fill.js
  • test/parallel/test-buffer-new.js
  • test/parallel/test-buffer-read.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 6, 2017
evanlucas
evanlucas approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

CI: https://ci.nodejs.org/job/node-test-pull-request/11910/

@mithunsasidharan mithunsasidharan mentioned this pull request Dec 8, 2017
Closed
3 tasks
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11986/

Was a little wonky last time, double-checking.

@apapirovski
Copy link
Member

Landed in 146a9b1

@apapirovski apapirovski closed this Dec 8, 2017
apapirovski pushed a commit that referenced this pull request Dec 8, 2017
@mithunsasidharan @apapirovski
test: replace assert.throws w/ common.expectsError
146a9b1 
PR-URL: #17483
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: replace assert.throws w/ common.expectsError
faae2ce 
PR-URL: #17483
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: replace assert.throws w/ common.expectsError
ff59d3a 
PR-URL: #17483
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mithunsasidharan @apapirovski @jasnell @evanlucas @cjihrig @BridgeAR @gibfahn @nodejs-github-bot