Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test-benchmark-dgram #17462

Closed
wants to merge 2 commits into from
Closed

test: add test-benchmark-dgram #17462

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 5, 2017

A continuation of #16113. (/cc @jopann)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark dgram

jopann and others added 2 commits December 4, 2017 17:00
@jopann @Trott
test: add dgram benchmark test
751ab11
@Trott
test: add more settings to test-benchmark-dgram
52f2487 
Add settings to test-benchmark-dgram such that it only runs benchmark
per benchmark file.
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels Dec 5, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 5, 2017
@Trott
Copy link
Member Author

Trott commented Dec 5, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11878/

@BridgeAR
Copy link
Member

BridgeAR commented Dec 6, 2017

This does not require 48 hours out of my perspective

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2017
@jopann @Trott
test: add dgram benchmark test
24ac1a4 
PR-URL: nodejs#17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Dec 6, 2017
@Trott
test: add more settings to test-benchmark-dgram
098b5b6 
Add settings to test-benchmark-dgram such that it only runs benchmark
per benchmark file.

PR-URL: nodejs#17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member Author

Trott commented Dec 6, 2017

Landed in 24ac1a4 and 098b5b6.

@Trott Trott closed this Dec 6, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@jopann @MylesBorins
test: add dgram benchmark test
6c9b795 
PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
test: add more settings to test-benchmark-dgram
6bc7fe8 
Add settings to test-benchmark-dgram such that it only runs benchmark
per benchmark file.

PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@jopann @MylesBorins
test: add dgram benchmark test
562007c 
PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
test: add more settings to test-benchmark-dgram
cca3526 
Add settings to test-benchmark-dgram such that it only runs benchmark
per benchmark file.

PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@jopann @gibfahn
test: add dgram benchmark test
6dea0f8 
PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: add more settings to test-benchmark-dgram
e4e1212 
Add settings to test-benchmark-dgram such that it only runs benchmark
per benchmark file.

PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@jopann @gibfahn
test: add dgram benchmark test
6c6635d 
PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: add more settings to test-benchmark-dgram
977eb5a 
Add settings to test-benchmark-dgram such that it only runs benchmark
per benchmark file.

PR-URL: #17462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@Trott Trott deleted the test-bench-dgram branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @BridgeAR @jasnell @cjihrig @gibfahn @nodejs-github-bot @jopann