doc: add info on post-publishing ARM6 builds #17455

mhdawson · 2017-12-04T15:23:47Z

ARM6 takes longer, more often fails builds than other
platforms. Add instructions for how to recover in this
case.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

gibfahn · 2017-12-04T17:35:02Z

doc/releases.md

+re-run the build only for ARM6.  When launching the build make sure to
+use the same commit hash as for the original release.
+
+**b.** Re-run steps 12-13 to promote and sign the release builds.


It would be good to specify the names of those sections in case the numbering gets changed later.

gibfahn · 2017-12-04T17:37:23Z

doc/releases.md

+
+The ARM6 builds take significantly longer to build than other platforms
+and are more prone to failure. For this reason a release may be published
+in advance of the ARM6 build being ready.  


This seems like it should be part of the step above:

If you didn't wait for ARM builds in the previous step before promoting the release, you should re-run tools/release.sh after the ARM builds have finished. That will move the ARM artifacts into the correct location. You will be prompted to re-sign SHASUMS256.txt.

I feel it at least should not be after 17. Celebrate (which implies everything is done). As @gibfahn points out, it's already kind of mentioned in 12. Promote and Sign the Release Builds but maybe it's not prominent enough because we have frequently forgotten to promote them (e.g. nodejs/nodejs.org#1382).

Also is there any particular reason to include the 6 and not just say ARM?

It is only the ARMv6 builds that are really slow.

mhdawson · 2017-12-04T22:47:05Z

@gibfahn updated to merge into that step.

gibfahn

LGTM with suggestion.

gibfahn · 2017-12-04T22:52:57Z

doc/releases.md

@@ -214,7 +214,9 @@ If you have an error on Windows and need to start again, be aware that you'll ge

 ARMv7 takes the longest to compile. Unfortunately ccache isn't as effective on release builds, I think it's because of the additional macro settings that go in to a release build that nullify previous builds. Also most of the release build machines are separate to the test build machines so they don't get any benefit from ongoing compiles between releases. You can expect 1.5 hours for the ARMv7 builder to complete and you should normally wait for this to finish. It is possible to rush a release out if you want and add additional builds later but we normally provide ARMv7 from initial promotion.

-You do not have to wait for the ARMv6 / Raspberry PI builds if they take longer than the others. It is only necessary to have the main Linux (x64 and x86), macOS .pkg and .tar.gz, Windows (x64 and x86) .msi and .exe, source, headers, and docs (both produced currently by an macOS worker). **If you promote builds _before_ ARM builds have finished, you must repeat the promotion step for the ARM builds when they are ready**.
+You do not have to wait for the ARMv6 / Raspberry PI builds if they take longer than the others. It is only necessary to have the main Linux (x64 and x86), macOS .pkg and .tar.gz, Windows (x64 and x86) .msi and .exe, source, headers, and docs (both produced currently by an macOS worker). **If you promote builds _before_ ARM builds have finished, you must repeat the promotion step for the ARM builds when they are ready**.  If the ARMv6 build failed for some
+reason you can use the `iojs-release-arm6-only` build in the release CI to re-run the build only for ARMv6.  When launching the build make sure to


Maybe make it:

[`iojs-release-arm6-only`](https://ci-release.nodejs.org/job/iojs+release-arm6-only/)

gibfahn · 2017-12-04T22:53:20Z

cc/ @nodejs/release

BridgeAR · 2017-12-06T01:33:25Z

doc/releases.md

@@ -214,7 +214,7 @@ If you have an error on Windows and need to start again, be aware that you'll ge

 ARMv7 takes the longest to compile. Unfortunately ccache isn't as effective on release builds, I think it's because of the additional macro settings that go in to a release build that nullify previous builds. Also most of the release build machines are separate to the test build machines so they don't get any benefit from ongoing compiles between releases. You can expect 1.5 hours for the ARMv7 builder to complete and you should normally wait for this to finish. It is possible to rush a release out if you want and add additional builds later but we normally provide ARMv7 from initial promotion.

-You do not have to wait for the ARMv6 / Raspberry PI builds if they take longer than the others. It is only necessary to have the main Linux (x64 and x86), macOS .pkg and .tar.gz, Windows (x64 and x86) .msi and .exe, source, headers, and docs (both produced currently by an macOS worker). **If you promote builds _before_ ARM builds have finished, you must repeat the promotion step for the ARM builds when they are ready**.
+You do not have to wait for the ARMv6 / Raspberry PI builds if they take longer than the others. It is only necessary to have the main Linux (x64 and x86), macOS .pkg and .tar.gz, Windows (x64 and x86) .msi and .exe, source, headers, and docs (both produced currently by an macOS worker). **If you promote builds _before_ ARM builds have finished, you must repeat the promotion step for the ARM builds when they are ready**.  If the ARMv6 build failed for some reason you can use the [`iojs-release-arm6-only`](https://ci-release.nodejs.org/job/iojs+release-arm6-only/) build in the release CI to re-run the build only for ARMv6.  When launching the build make sure to use the same commit hash as for the original release.


Nit - Since the other sentences only use a single whitespace after a sentence, I would suggest to do the same here?

mhdawson · 2017-12-07T21:34:14Z

Will do, its hard to overcome many years at school (in the past) where 2 spaces was the only way :)

mhdawson · 2017-12-08T17:37:23Z

CI run: https://ci.nodejs.org/job/node-test-commit/14680/

mhdawson · 2017-12-08T17:38:52Z

CI looks good landing.

ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case.

mhdawson · 2017-12-08T17:59:56Z

Landed as 4e65f9d

ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case. PR-URL: #17455 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 4, 2017

mhdawson requested a review from gibfahn December 4, 2017 15:28

mhdawson mentioned this pull request Dec 4, 2017

no ARMv6 download of Nodejs 8.x available, 404 link nodejs/nodejs.org#1382

Closed

mscdex added the build Issues and PRs related to build files or the CI. label Dec 4, 2017

gibfahn reviewed Dec 4, 2017

View reviewed changes

gibfahn approved these changes Dec 4, 2017

View reviewed changes

lpinca approved these changes Dec 5, 2017

View reviewed changes

BridgeAR reviewed Dec 6, 2017

View reviewed changes

MylesBorins force-pushed the master branch from b7405ab to 7f086dd Compare December 8, 2017 16:37

doc: add info on post-publishing ARM6 builds

a19b15a

ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case.

mhdawson force-pushed the arm branch from ea9d64d to a19b15a Compare December 8, 2017 17:43

mhdawson closed this Dec 8, 2017

MylesBorins mentioned this pull request Dec 12, 2017

v9.3.0 proposal #17631

Merged

gibfahn added dont-land-on-v6.x labels Dec 20, 2017

gibfahn mentioned this pull request Dec 20, 2017

v8.9.4 proposal #17772

Closed

gibfahn mentioned this pull request Dec 20, 2017

v8.9.4 proposal #17774

Merged

mhdawson deleted the arm branch September 30, 2019 13:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: add info on post-publishing ARM6 builds #17455

doc: add info on post-publishing ARM6 builds #17455

mhdawson commented Dec 4, 2017

gibfahn Dec 4, 2017

gibfahn Dec 4, 2017

richardlau Dec 4, 2017

mhdawson Dec 4, 2017

mhdawson commented Dec 4, 2017

gibfahn left a comment

gibfahn Dec 4, 2017

mhdawson Dec 4, 2017

gibfahn commented Dec 4, 2017

BridgeAR Dec 6, 2017

mhdawson commented Dec 7, 2017

mhdawson commented Dec 8, 2017 •

edited

Loading

mhdawson commented Dec 8, 2017

mhdawson commented Dec 8, 2017

doc: add info on post-publishing ARM6 builds #17455

doc: add info on post-publishing ARM6 builds #17455

Conversation

mhdawson commented Dec 4, 2017

Checklist

Affected core subsystem(s)

gibfahn Dec 4, 2017

Choose a reason for hiding this comment

gibfahn Dec 4, 2017

Choose a reason for hiding this comment

richardlau Dec 4, 2017

Choose a reason for hiding this comment

mhdawson Dec 4, 2017

Choose a reason for hiding this comment

mhdawson commented Dec 4, 2017

gibfahn left a comment

Choose a reason for hiding this comment

gibfahn Dec 4, 2017

Choose a reason for hiding this comment

mhdawson Dec 4, 2017

Choose a reason for hiding this comment

gibfahn commented Dec 4, 2017

BridgeAR Dec 6, 2017

Choose a reason for hiding this comment

mhdawson commented Dec 7, 2017

mhdawson commented Dec 8, 2017 • edited Loading

mhdawson commented Dec 8, 2017

mhdawson commented Dec 8, 2017

mhdawson commented Dec 8, 2017 •

edited

Loading