Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.mustCall in http test #17439

Closed
wants to merge 1 commit into from
Closed

test: use common.mustCall in http test #17439

wants to merge 1 commit into from

Conversation

mithunsasidharan
Copy link
Contributor

@mithunsasidharan mithunsasidharan commented Dec 3, 2017 •
edited
Loading

Refactored the test case in test-http-malformed-request to use common.mustCall, as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2017
apapirovski
apapirovski reviewed Dec 3, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should instead be refactored to use common.mustCall for the response function passed to http.createServer. The nrequests_completed and nrequests_expected variables should still be removed. The server.close() can just be unconditional.

@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Thanks for the feedback. I've updated the PR to include the recommended changes. Kindly review the PR now.

apapirovski
apapirovski approved these changes Dec 3, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commit message & PR title should be updated

@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11858/

@mithunsasidharan mithunsasidharan changed the title refactor : test-http-malformed-request to use countdown refactor : test-http-malformed-request to use common#mustCall Dec 3, 2017
@mithunsasidharan mithunsasidharan changed the title refactor : test-http-malformed-request to use common#mustCall refactor : test-http-malformed-request to use common.mustCall Dec 3, 2017
@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Thats's done too.. Thanks.

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Dec 3, 2017
@apapirovski
Copy link
Member

apapirovski commented Dec 3, 2017 •
edited
Loading

The commit message is still too long. Something like test: use common.mustCall in http test would be fine. We don't need to specify the exact test file changed within the message. Thanks!

@mithunsasidharan mithunsasidharan changed the title refactor : test-http-malformed-request to use common.mustCall test: use common.mustCall in http test Dec 3, 2017
@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Thanks for the feedback. I've updated the commit message. Kindly review the PR now.

apapirovski
apapirovski approved these changes Dec 3, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2017
@maclover7
Copy link
Contributor

Landing...

@maclover7 maclover7 self-assigned this Dec 5, 2017
@maclover7
Copy link
Contributor

Thank you for your contribution, landed in f6b2839.
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 5, 2017
maclover7 pushed a commit to maclover7/node that referenced this pull request Dec 5, 2017
@mithunsasidharan @maclover7
test: use common.mustCall in test-http-malformed-request
f6b2839 
PR-URL: nodejs#17439
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: use common.mustCall in test-http-malformed-request
68330b9 
PR-URL: #17439
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: use common.mustCall in test-http-malformed-request
07fd4cf 
PR-URL: #17439
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan @gibfahn
test: use common.mustCall in test-http-malformed-request
f9adf51 
PR-URL: #17439
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan @gibfahn
test: use common.mustCall in test-http-malformed-request
876966f 
PR-URL: #17439
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan @gibfahn
test: use common.mustCall in test-http-malformed-request
daa0cab 
PR-URL: #17439
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@maclover7 maclover7 maclover7 approved these changes

@tniessen tniessen tniessen approved these changes

@daxlab daxlab daxlab approved these changes

Assignees

@maclover7 maclover7

Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.