Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: minor refinements to TimersList & stricter undefined/null checks #17429

Closed
wants to merge 2 commits into from
Closed

timers: minor refinements to TimersList & stricter undefined/null checks #17429

wants to merge 2 commits into from

Commits on Dec 7, 2017

  1. timers: improvements to TimersList management 

    No longer use delete to remove keys on unrefed & refed lists,
instead simply set to undefined.

Move all the TimersList instantiation code into the constructor.

Compare values to undefined & null as appropriate instead of
truthy or falsy.
    @apapirovski
    apapirovski committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    5ecc4a9 View commit details
    Browse the repository at this point in the history

  2. timers: compare to null not falsey

    @apapirovski
    apapirovski committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    253341a View commit details
    Browse the repository at this point in the history