Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test case for missing branch #17418

Closed
wants to merge 2 commits into from
Closed

test: Add test case for missing branch #17418

wants to merge 2 commits into from

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Dec 1, 2017

Enhance crypto/util coverage.
I added:

  • The case of id is string, flags is number
  • The case of flags is not 0

Current coverage:
screen shot 2017-12-02 at 3 17 39
https://coverage.nodejs.org/coverage-06e1b0386196f8f8/root/internal/crypto/util.js.html

After this PR:
screen shot 2017-12-02 at 3 24 45

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Leko
test: Add test case for missing branch
8dade49 
- The case of id is string, flags is number
- The case of flags is not 0
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2017
cjihrig
cjihrig approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps use the name invalidEngineName instead of notExistsEngineName.

addaleax
addaleax approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @cjihrig's suggestion too

apapirovski
apapirovski approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but +1 to @cjihrig's naming suggestion

@Leko
Copy link
Contributor Author

Leko commented Dec 2, 2017

slightly off topic, but what software are you using for visualizing the coverage report

@devsnek I'm using make -j4 coverage-test to generate coverage report.

@Leko
Copy link
Contributor Author

Leko commented Dec 2, 2017

@cjihrig Thank you for review.
I'll rename it as your suggestion.

@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Dec 2, 2017
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11853/

@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 3, 2017
@maclover7
Copy link
Contributor

windows-fanned failure seems unrelated, landing...

@maclover7 maclover7 self-assigned this Dec 3, 2017
@maclover7
Copy link
Contributor

Thank you for your contribution, landed in 254b5f0.
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 3, 2017
maclover7 pushed a commit that referenced this pull request Dec 3, 2017
@Leko @maclover7
test: add test case for missing branch
254b5f0 
- The case of id is string, flags is number
- The case of flags is not 0

PR-URL: #17418
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@Leko Leko deleted the enhance_crypto_coverage branch December 4, 2017 05:31
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Leko @MylesBorins
test: add test case for missing branch
e36d43f 
- The case of id is string, flags is number
- The case of flags is not 0

PR-URL: #17418
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Leko @MylesBorins
test: add test case for missing branch
0afcea2 
- The case of id is string, flags is number
- The case of flags is not 0

PR-URL: #17418
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@Leko Leko mentioned this pull request Dec 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

Assignees

@maclover7 maclover7

Labels
crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Leko @apapirovski @maclover7 @addaleax @lpinca @cjihrig @mscdex @gibfahn @nodejs-github-bot