Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use uv_os_getpid() to get process id #17415

Merged
merged 1 commit into from
Dec 4, 2017
Merged

src: use uv_os_getpid() to get process id #17415

merged 1 commit into from
Dec 4, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 1, 2017

This commit uses the new uv_os_getpid() method to retrieve the
current process id.

I currently left GetProcessId() in util.cc. Not sure if it should be removed or not.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 1, 2017
@bnoordhuis
Copy link
Member

bnoordhuis commented Dec 1, 2017 •
edited
Loading

I'd just remove GetProcessId(), it serves no purpose now.

(edit: I guess it ensures that you're always dealing with a uint32_t, which is useful in format strings.)

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 1, 2017

I just pushed an updated commit that removes it, and just saw your edit. Should I put it back?

bnoordhuis
bnoordhuis approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it's fine. It's 32 bits on all our platforms so it probably makes no practical difference.

@richardlau
Copy link
Member

We should be consistent -- either it stays and the rest of the code base uses it or it is removed and the code base directly calls uv_os_getpid().

@Fishrock123
Copy link
Contributor

Can uv_os_getpid() fail? If not it doesn't matter but if it can I guess we could fall back to that stuff?

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 1, 2017

It cannot.

@bnoordhuis
Copy link
Member

getpid() can fail on Linux in a seccomp2 sandbox. The sandbox can reject the system call with an ENOSYS error, for example.

But that's probably an academical concern, and arguably a bug in the sandbox, not the application.

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 2, 2017

TIL. We also wouldn't use the old code as a fallback since uv_os_getpid() is built using it 😄

@cjihrig
src: use uv_os_getpid() to get process id
a803bca 
This commit uses the new uv_os_getpid() method to retrieve the
current process id.

PR-URL: nodejs#17415
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Khaidi Chu <i@2333.moe>
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 4, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11869/

@cjihrig cjihrig merged commit a803bca into nodejs:master Dec 4, 2017
@cjihrig cjihrig deleted the getpid branch December 4, 2017 15:38
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@cjihrig @MylesBorins
src: use uv_os_getpid() to get process id
6adaed0 
This commit uses the new uv_os_getpid() method to retrieve the
current process id.

PR-URL: #17415
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Khaidi Chu <i@2333.moe>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@cjihrig @MylesBorins
src: use uv_os_getpid() to get process id
40acda2 
This commit uses the new uv_os_getpid() method to retrieve the
current process id.

PR-URL: #17415
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Khaidi Chu <i@2333.moe>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@gibfahn
Copy link
Member

gibfahn commented Dec 20, 2017

Should be good to land in the next 6.x and 8.x releases.

@richardlau
Copy link
Member

@gibfahn FYI this PR depends on libuv 1.18.0.

@MylesBorins
Copy link
Contributor

@richardlau I think we'll be updating libuv in the next version (as long as it doesn't change gcc requirements)

gibfahn pushed a commit that referenced this pull request Feb 19, 2018
@cjihrig @gibfahn
src: use uv_os_getpid() to get process id
d47cb9a 
This commit uses the new uv_os_getpid() method to retrieve the
current process id.

PR-URL: #17415
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Khaidi Chu <i@2333.moe>
@MylesBorins
Copy link
Contributor

6.x is currently running on libuv 1.16.1, so I'm setting this to don't-land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@addaleax addaleax addaleax approved these changes

@XadillaX XadillaX XadillaX approved these changes

@maclover7 maclover7 maclover7 approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.