Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: remove post-gc event infrastructure #174

Merged
merged 1 commit into from
Dec 18, 2014
Merged

lib,src: remove post-gc event infrastructure #174

merged 1 commit into from
Dec 18, 2014

Commits on Dec 18, 2014

  1. lib,src: remove post-gc event infrastructure 

    Remove the 'gc' event from the v8 module and remove the supporting
infrastructure from src/.  It gets the axe because:

1. There are currently no users.  It was originally conceived as
   an upstreamed subset of StrongLoop's strong-agent GC metrics,
   but the strong-agent code base has evolved considerably since
   that time and has no use anymore for what is in core.

2. The implementation is not quite sound.  It calls into JS land
   from inside the GC epilog and that is unsafe.  We could fix
   that by delaying the callback until a safe time but because
   there are no users anyway, removing it is all around easier.

PR-URL: nodejs#174
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Dec 18, 2014
    Configuration menu
    Copy the full SHA
    dab6f68 View commit details
    Browse the repository at this point in the history