tools,test: use Execute instead of check_output #17381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
4 tasks
|
Seems like this is the safest way to restore CI to green, so we should to fast-track this. |
Trott
added
the
python
Merged
MylesBorins
approved these changes
Nov 29, 2017
bnoordhuis
approved these changes
Nov 29, 2017
tools/test.py
Outdated
| if "fips" in subprocess.check_output([vm, "-p", | ||
| "process.versions.openssl"]): | ||
| ssl_ver = Execute([vm, "-p", "process.versions.openssl"], context).stdout | ||
| if "fips" in ssl_ver: |
There was a problem hiding this comment.
Since you're here, can you use single quotes?
gibfahn
approved these changes
Nov 29, 2017
|
+1 on fast-track |
refack
force-pushed
the
improve-testpy-subprocess
branch
from
12f9684
to
f4d1bb8
Compare
refack
force-pushed
the
improve-testpy-subprocess
branch
from
f4d1bb8
to
6998621
Compare
subprocess.check_output is a python2.7 only feature. Using Execute allows keeping python2.6 compatibility PR-URL: nodejs#17381 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
refack
force-pushed
the
improve-testpy-subprocess
branch
from
6998621
to
fff3792
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
subprocess.check_output is a python2.7 only feature. Using Execute allows keeping python2.6 compatibility PR-URL: #17381 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
subprocess.check_output is a python2.7 only feature. Using Execute allows keeping python2.6 compatibility PR-URL: #17381 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
subprocess.check_output is a python2.7 only feature. Using Execute allows keeping python2.6 compatibility PR-URL: #17381 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Backport requested here: #16329 (comment) |
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
subprocess.check_output is a python2.7 only feature. Using Execute allows keeping python2.6 compatibility PR-URL: #17381 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.check_output(f31cf56) is a python2.7 only feature. Using Execute allowskeeping python2.6 compatibility
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools,test