Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky parallel/test-http2-client-upload #17361

Closed

Commits on Nov 27, 2017

  1. test: fix flaky parallel/test-http2-client-upload

    In parallel/test-http2-client-upload, the `client.destroy()`
    call could terminate the connection before all data was sent
    over the wire successfully.
    
    Using `client.shutdown()` removes the flakiness.
    
    Also, listen on `req.on('finish')` rather than the file stream’s
    `end` event, since we’re not interested in when the source stream
    finishes, but rather when the HTTP/2 stream finishes.
    
    Refs: nodejs#17356
    addaleax committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    31861a7 View commit details
    Browse the repository at this point in the history