test: updated test case in test-http-timeout to use countdown
#17341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxlab
approved these changes
Nov 27, 2017
mithunsasidharan
changed the title
test-http-timeout to use countdowntest-http-timeout to use countdown
mithunsasidharan
changed the title
test-http-timeout to use countdowntest-http-timeout to use countdown
maclover7
approved these changes
Nov 27, 2017
|
@apapirovski : Can you please run the CI for this too ? |
|
@mithunsasidharan Looks like there's a CI and it's green other than known failures. |
apapirovski
approved these changes
Dec 3, 2017
apapirovski
reviewed
Dec 3, 2017
test/parallel/test-http-timeout.js
Outdated
|
|
||
| const server = http.createServer(function(req, res) { | ||
| res.writeHead(200, { 'Content-Type': 'text/plain' }); | ||
| res.end('OK'); | ||
| }); | ||
|
|
||
| const agent = new http.Agent({ maxSockets: 1 }); | ||
| const countdown = new Countdown(11, () => server.close()); |
There was a problem hiding this comment.
Could you store 11 in a const? Thanks!
There was a problem hiding this comment.
@apapirovski : Update the PR to address the review comment and also shortened the commit message. Kindly review now.Thanks!
|
LGTM but one general nit that applies to all the PRs: the colon after the subsystem shouldn't have a space before it, so |
mithunsasidharan
changed the title
test-http-timeout to use countdowntest-http-timeout to use countdown
|
@apapirovski : Thanks much for the support ! |
maclover7
added
the
author ready
|
Landing... |
|
Thank you for your contribution, landed in 996bfcc. |
maclover7
pushed a commit
that referenced
this pull request
Dec 4, 2017
PR-URL: #17341 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17341 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17341 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17341 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17341 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test : Updated test case in
test-http-timeoutto use countdown as per issue #17169Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test