doc: Update HTTP -> HTTPS in doc/api #17263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Nov 22, 2017
maclover7
reviewed
Nov 23, 2017
doc/api/crypto.md
Outdated
| @@ -2396,7 +2396,7 @@ the `crypto`, `tls`, and `https` modules and are generally specific to OpenSSL. | |||
| [`verify.verify()`]: #crypto_verify_verify_object_signature_signatureformat | |||
| [Caveats]: #crypto_support_for_weak_or_compromised_algorithms | |||
| [Crypto Constants]: #crypto_crypto_constants_1 | |||
| [HTML5's `keygen` element]: http://www.w3.org/TR/html5/forms.html#the-keygen-element | |||
| [HTML5's `keygen` element]: https://www.w3.org/TR/html5/forms.html#the-keygen-elementt | |||
There was a problem hiding this comment.
possible typo, should this be element?
him2him2
force-pushed
the
_Fix_doc/api_HTTPS
branch
from
6fae714
to
907a9ef
Compare
|
@maclover7 Nice catch. Thanks for the second set of eyes. I have fixed the typo. |
MylesBorins
approved these changes
Nov 23, 2017
MylesBorins
added
the
fast-track
URLs were updated to use HTTPS protocol in doc/api files. Update URLs to reduce 301 Redirects for speed.
him2him2
force-pushed
the
_Fix_doc/api_HTTPS
branch
from
907a9ef
to
4686458
Compare
him2him2
changed the title
lpinca
approved these changes
Nov 23, 2017
apapirovski
approved these changes
Nov 23, 2017
|
Landed in 7ab7840 Thank you for the contribution! |
apapirovski
pushed a commit
that referenced
this pull request
Nov 23, 2017
PR-URL: #17263 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17263 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17263 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17263 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17263 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs were updated to use HTTPS protocol in doc/api files.
Update URLs to reduce 301 Redirects for speed.
Checklist
Affected core subsystem(s)
doc