Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/doc: add tools/remark-* to eslintignore #17240

Closed
wants to merge 1 commit into from
Closed

tools/doc: add tools/remark-* to eslintignore #17240

wants to merge 1 commit into from

Conversation

IvanWei
Copy link
Contributor

@IvanWei IvanWei commented Nov 22, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 22, 2017
@IvanWei IvanWei mentioned this pull request Nov 22, 2017
Closed
2 tasks
@MylesBorins MylesBorins added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@joyeecheung
Copy link
Member

I am kind of wondering why are those remark-* not under tools/doc/node_modules? @watilde

@MylesBorins
Copy link
Contributor

Landed in c2c4dd4

Congrats on your first PR on core 🎉🎉🎉

MylesBorins pushed a commit that referenced this pull request Nov 23, 2017
@IvanWei @MylesBorins
tools/doc: add tools/remark-* to eslintignore
c2c4dd4 
PR-URL: #17240
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@IvanWei
Copy link
Contributor Author

IvanWei commented Nov 23, 2017

@MylesBorins

This is my second PR on core. 😄
( First PR: #17227)

I'm happy that you're coming Taiwan.
But my English is weak, I don't know how could I tell you that I'm excited last night. 😢

@IvanWei IvanWei deleted the featrue/add_new_file_to_eslintignore branch November 27, 2017 04:20
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@IvanWei @MylesBorins
tools/doc: add tools/remark-* to eslintignore
9c1ff6c 
PR-URL: #17240
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@IvanWei @MylesBorins
tools/doc: add tools/remark-* to eslintignore
623b589 
PR-URL: #17240
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@IvanWei @gibfahn
tools/doc: add tools/remark-* to eslintignore
c1b02b9 
PR-URL: #17240
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@IvanWei @gibfahn
tools/doc: add tools/remark-* to eslintignore
62ad4cc 
PR-URL: #17240
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@IvanWei @joyeecheung @MylesBorins @jasnell @benjamingr @cjihrig @gibfahn @nodejs-github-bot