Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add crashOnUnhandledRejection() on test-async-hooks-enable-during-promise.js #17234

Closed
wants to merge 1 commit into from
Closed

test: add crashOnUnhandledRejection() on test-async-hooks-enable-during-promise.js #17234

wants to merge 1 commit into from

Conversation

w5151381guy
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added the async_hooks Issues and PRs related to the async hooks subsystem. label Nov 22, 2017
@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11654/

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 26, 2017 •
edited
Loading

landed in bce5cba

edit: added missing semi-colon and slight tweak to commit meta data

MylesBorins pushed a commit that referenced this pull request Nov 26, 2017
@w5151381guy @MylesBorins
test: add common.crashOnUnhandledRejection()
bce5cba 
added to test-async-hooks-enable-during-promise.js

PR-URL: #17234
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@w5151381guy @MylesBorins
test: add common.crashOnUnhandledRejection()
f958b24 
added to test-async-hooks-enable-during-promise.js

PR-URL: #17234
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@w5151381guy @MylesBorins
test: add common.crashOnUnhandledRejection()
497195a 
added to test-async-hooks-enable-during-promise.js

PR-URL: #17234
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@w5151381guy @gibfahn
test: add common.crashOnUnhandledRejection()
11fd745 
added to test-async-hooks-enable-during-promise.js

PR-URL: #17234
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@w5151381guy @gibfahn
test: add common.crashOnUnhandledRejection()
0fb5d27 
added to test-async-hooks-enable-during-promise.js

PR-URL: #17234
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@w5151381guy @MylesBorins @jasnell @cjihrig @gireeshpunathil @mscdex @gibfahn @nodejs-github-bot