Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.crashOnUnhandledRejection() #17232

Closed
wants to merge 1 commit into from
Closed

test: use common.crashOnUnhandledRejection() #17232

wants to merge 1 commit into from

Conversation

sorarize
Copy link
Contributor

Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-run.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@sorarize
test: use common.crashOnUnhandledRejection()
4aa39a2 
Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-run.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2017
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11646/

jasnell pushed a commit that referenced this pull request Nov 23, 2017
@sorarize @jasnell
test: use common.crashOnUnhandledRejection()
6b87407 
Add common.crashOnUnhandledRejection to
test/parallel/test-microtask-queue-run.js

PR-URL: #17232
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 23, 2017

Landed in the 🎉 20,000th 🎉 commit to core, #6b87407! Thank you and congrats on the PR to core!

(fyi... jenkins died during the final run of freebsd on this PR but it was after this test had already passed)

@jasnell jasnell closed this Nov 23, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@sorarize @MylesBorins
test: use common.crashOnUnhandledRejection()
32d9c09 
Add common.crashOnUnhandledRejection to
test/parallel/test-microtask-queue-run.js

PR-URL: #17232
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@sorarize @MylesBorins
test: use common.crashOnUnhandledRejection()
8d1ec5d 
Add common.crashOnUnhandledRejection to
test/parallel/test-microtask-queue-run.js

PR-URL: #17232
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@sorarize @gibfahn
test: use common.crashOnUnhandledRejection()
8695511 
Add common.crashOnUnhandledRejection to
test/parallel/test-microtask-queue-run.js

PR-URL: #17232
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@sorarize @MylesBorins
test: use common.crashOnUnhandledRejection()
699659e 
Add common.crashOnUnhandledRejection to
test/parallel/test-microtask-queue-run.js

PR-URL: #17232
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@sorarize @gibfahn
test: use common.crashOnUnhandledRejection()
bea9200 
Add common.crashOnUnhandledRejection to
test/parallel/test-microtask-queue-run.js

PR-URL: #17232
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sorarize @jasnell @MylesBorins @cjihrig @gireeshpunathil @mscdex @gibfahn @nodejs-github-bot