Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.crashOnUnhandledRejection #17215

Closed
wants to merge 1 commit into from
Closed

test: use common.crashOnUnhandledRejection #17215

wants to merge 1 commit into from

Conversation

sj82516
Copy link
Contributor

@sj82516 sj82516 commented Nov 22, 2017 •
edited
Loading

Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-integration-domain.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11613/

danbev
danbev approved these changes Nov 22, 2017
View reviewed changes
test/parallel/test-microtask-queue-integration-domain.js
@@ -30,6 +30,9 @@ const assert = require('assert');
// removed.
require('domain');

// add crash handler for unhandled rejection
common.crashOnUnhandledRejection();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think common needs to be declared first:

const common = require('../common');

@MylesBorins MylesBorins added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@gireeshpunathil
Copy link
Member

@sj82516 - your second commit brought about 94 files - accidental?

@sj82516
Copy link
Contributor Author

sj82516 commented Nov 22, 2017

I run make -j4 test for test and then it installed the node modules.
I will remove the unnecessary part.
Sorry about that

@mscdex
Copy link
Contributor

mscdex commented Nov 22, 2017

It seems a bunch of pre-existing node modules are now being removed?

@mscdex mscdex added domain Issues and PRs related to the domain subsystem. process Issues and PRs related to the process subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2017
@sj82516
Copy link
Contributor Author

sj82516 commented Nov 22, 2017

yes, I removed them.
Sorry for the accident

jasnell
jasnell previously approved these changes Nov 22, 2017
View reviewed changes
@jasnell jasnell dismissed their stale review November 22, 2017 16:15

Removing my sign off until the extraneous commits can be cleaned up

jasnell
jasnell requested changes Nov 22, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to be reworked to remove the extraneous edits

@sj82516
Copy link
Contributor Author

sj82516 commented Nov 23, 2017

I rebase the commit and push force again.
Is that correct now ?
Sorry for the first time PR to the nodejs project.

@mscdex
Copy link
Contributor

mscdex commented Nov 23, 2017

Still the same problem. I think you will need to edit your commit since it seems the file removals are a part of the same commit as your actual (test) changes.

@sj82516
remove extra instructions.
d47c150 
reset the commit to remvoe extra instructions.
@sj82516
Copy link
Contributor Author

sj82516 commented Nov 23, 2017

I see.
So I would reset and rewrite the commit.
Should I push force to this PR or cancel this PR and create new one ?

@MylesBorins
Copy link
Contributor

@sj82516 you can always force push over the branch you made the PR with

@mscdex
Copy link
Contributor

mscdex commented Nov 23, 2017

Looks better now.

@targos
Copy link
Member

targos commented Nov 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11671/

MylesBorins pushed a commit that referenced this pull request Nov 26, 2017
@sj82516 @MylesBorins
test: use common.crashOnUnhandledRejection
7518617 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins
Copy link
Contributor

landed in 7518617 with some minor nits addressed

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@sj82516 @MylesBorins
test: use common.crashOnUnhandledRejection
72a7147 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@sj82516 @MylesBorins
test: use common.crashOnUnhandledRejection
c375816 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@sj82516 @gibfahn
test: use common.crashOnUnhandledRejection
e73c191 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@sj82516 @gibfahn
test: use common.crashOnUnhandledRejection
b63f51a 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@sj82516 @gibfahn
test: use common.crashOnUnhandledRejection
e07c200 
PR-URL: #17215
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell requested changes

@danbev danbev danbev approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sj82516 @MylesBorins @gireeshpunathil @mscdex @targos @danbev @jasnell @gibfahn @nodejs-github-bot