Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.crashOnUnhandledRejection #17214

Closed
wants to merge 1 commit into from
Closed

test: use common.crashOnUnhandledRejection #17214

wants to merge 1 commit into from

Conversation

madeinfree
Copy link
Contributor

Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-run-immediate.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
@madeinfree
test: use common.crashOnUnhandledRejection
b2b97f2 
Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-run-immediate.js
@madeinfree madeinfree force-pushed the add-crash-on-unhandled-rejection branch from a7b87e3 to b2b97f2 Compare November 22, 2017 08:34
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11614/

@MylesBorins MylesBorins added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added process Issues and PRs related to the process subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2017
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Failure in CI is unrelated.

jasnell pushed a commit that referenced this pull request Nov 22, 2017
@madeinfree @jasnell
test: use common.crashOnUnhandledRejection
bd5acfe 
Add common.crashOnUnhandledRejection to
test-microtask-queue-run-immediate.js

PR-URL: #17214
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Landed in bd5acfe! Thank you and congrats on your first PR to core!

@jasnell jasnell closed this Nov 22, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@madeinfree @MylesBorins
test: use common.crashOnUnhandledRejection
039fc8f 
Add common.crashOnUnhandledRejection to
test-microtask-queue-run-immediate.js

PR-URL: #17214
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@madeinfree @MylesBorins
test: use common.crashOnUnhandledRejection
965051d 
Add common.crashOnUnhandledRejection to
test-microtask-queue-run-immediate.js

PR-URL: #17214
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@madeinfree @MylesBorins
test: use common.crashOnUnhandledRejection
e7ca894 
Add common.crashOnUnhandledRejection to
test-microtask-queue-run-immediate.js

PR-URL: #17214
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@madeinfree @gibfahn
test: use common.crashOnUnhandledRejection
d328e06 
Add common.crashOnUnhandledRejection to
test-microtask-queue-run-immediate.js

PR-URL: #17214
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@madeinfree @gibfahn
test: use common.crashOnUnhandledRejection
f608f70 
Add common.crashOnUnhandledRejection to
test-microtask-queue-run-immediate.js

PR-URL: #17214
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@madeinfree @MylesBorins @jasnell @danbev @cjihrig @gireeshpunathil @mscdex @gibfahn @nodejs-github-bot