Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unprofessional slang in assertions #17166

Closed
wants to merge 1 commit into from
Closed

src: remove unprofessional slang in assertions #17166

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Nov 21, 2017

Hi 👋
Sorry for being absent for quite a bit of time, but I'm back here to
send some pull requests and whatnot :D

Convert CHECK(0 && "wtf?") (sic) assertions to more suitable
UNREACHABLE() macro invocations in node_zlib.cc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@aqrln
src: remove unprofessional slang in assertions
876f27a 
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem. labels Nov 21, 2017
@aqrln
Copy link
Contributor Author

aqrln commented Nov 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11568/

@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

This doesn't need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Nov 21, 2017
@aqrln @jasnell
src: remove unprofessional slang in assertions
4b34e6f 
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.

PR-URL: #17166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Landed in 4b34e6f

@jasnell jasnell closed this Nov 21, 2017
@aqrln aqrln deleted the weird-check-to-unreachable branch November 21, 2017 16:04
@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@aqrln @MylesBorins
src: remove unprofessional slang in assertions
9c0c336 
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.

PR-URL: #17166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@aqrln @gibfahn
src: remove unprofessional slang in assertions
e90c836 
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.

PR-URL: #17166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@aqrln @MylesBorins
src: remove unprofessional slang in assertions
84a8861 
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.

PR-URL: #17166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@aqrln @gibfahn
src: remove unprofessional slang in assertions
f26b576 
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.

PR-URL: #17166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.