Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promises/better unhandled rejection message #17158

Closed
wants to merge 6 commits into from
Closed

Promises/better unhandled rejection message #17158

wants to merge 6 commits into from

Commits on Nov 20, 2017

  1. Improved unhandled rejection message 

    Fixes nodejs#16768
    @MadaraUchiha
    MadaraUchiha committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    a29fe91 View commit details
    Browse the repository at this point in the history

  2. Make tests pass 

    For unhandled rejection error message change.
    @MadaraUchiha
    MadaraUchiha committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    ba4adc5 View commit details
    Browse the repository at this point in the history

  3. Wrap reason with unsafeToString() if it's a string

    @MadaraUchiha
    MadaraUchiha committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    ab45e60 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. Add test for checking warnings about rejected numbers. 

    Also clean up the test a bit and add comments
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    bf06851 View commit details
    Browse the repository at this point in the history

  2. Fix failing symbol rejection test. 

    Now checks correctly that Symbol() is outputted when rejection happens.
    @MadaraUchiha
    MadaraUchiha committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    9d29f0c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Make test lines wrap at 80 characters or less.

    @MadaraUchiha
    MadaraUchiha committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    481c7f1 View commit details
    Browse the repository at this point in the history