doc: add Table of Contents to Cpp style guide #17052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cpp style guide is growing. IMHO, a Table of Contents makes it easier to navigate.
fhinkel
force-pushed
the
nov/cpp_style_guide
branch
from
bbb003f
to
c779a97
Compare
fhinkel
changed the title
addaleax
approved these changes
Nov 15, 2017
2 tasks
joyeecheung
reviewed
Nov 15, 2017
| @@ -1,5 +1,22 @@ | |||
| # C++ Style Guide | |||
|
|
|||
| ## Table of Contents | |||
|
|
|||
| * [Left-leaning (C++ style) asterisks for pointer declarations](#left-leaning-c-style-asterisks-for-pointer-declarations) | |||
There was a problem hiding this comment.
Can we group the rules into different categories? For what we have here I think we should at least have "formatting", "memory management" and "others", also I would expect more from "C++ and JavaScript interfacing"
There was a problem hiding this comment.
Sure. Is it OK to do that in a separate PR?
cjihrig
approved these changes
Nov 15, 2017
richardlau
approved these changes
Nov 16, 2017
danbev
approved these changes
Nov 16, 2017
|
Thanks for the reviews. Fast-track landed in ed0327b (uncontroversial doc change). |
fhinkel
added a commit
that referenced
this pull request
Nov 16, 2017
The Cpp style guide is growing. IMHO, a Table of Contents makes it easier to navigate. PR-URL: #17052 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
2 tasks
fhinkel
added a commit
to fhinkel/node
that referenced
this pull request
Dec 3, 2017
fhinkel
added a commit
to fhinkel/node
that referenced
this pull request
Dec 3, 2017
Ref: nodejs#17052 (comment) PR-URL: nodejs#17095 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
The Cpp style guide is growing. IMHO, a Table of Contents makes it easier to navigate. PR-URL: #17052 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Ref: #17052 (comment) PR-URL: #17095 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Ref: #17052 (comment) PR-URL: #17095 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
The Cpp style guide is growing. IMHO, a Table of Contents makes it easier to navigate. PR-URL: #17052 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Ref: #17052 (comment) PR-URL: #17095 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
The Cpp style guide is growing. IMHO, a Table of Contents makes it easier to navigate. PR-URL: #17052 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Ref: #17052 (comment) PR-URL: #17095 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cpp style guide is growing. IMHO, a Table of Contents makes
it easier to navigate.
I checked all the anchors and made sure they work.
Checklist
Affected core subsystem(s)
doc