http, stream: writeHWM -> writableHighWaterMark #17050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I landed a broken commit 157df5a. Can I fast track this? Or force-push master? cc @nodejs/tsc |
calvinmetcalf
approved these changes
Nov 15, 2017
jasnell
approved these changes
Nov 15, 2017
|
+1 for fast track |
cjihrig
approved these changes
Nov 15, 2017
|
Landed as 3eb5778. |
mcollina
added a commit
that referenced
this pull request
Nov 15, 2017
See: #12860 (review) PR-URL: #17050 Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
See: #12860 (review) PR-URL: #17050 Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
|
@mcollina should this be backported to v6.x or v8.x. It will need to be manually backported for both. |
|
ping @mcollina |
|
I would not backport it to v6. However it needs to be backported together with: fdf9601 (which is already in staging). I won't be in the condition to do a backport for a week or two, so you might want to pull the above commit (or do both). I can review. |
gibfahn
pushed a commit
that referenced
this pull request
Jan 27, 2018
See: #12860 (review) PR-URL: #17050 Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #12860 (review)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http, stream