Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: bump remark-cli to 4.0 #17028

Closed
wants to merge 1 commit into from
Closed

tools: bump remark-cli to 4.0 #17028

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 14, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@refack refack requested a review from watilde November 14, 2017 21:25
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 14, 2017
@refack
Copy link
Contributor Author

refack commented Nov 14, 2017

/CC @nodejs/documentation @wooorm

@refack refack self-assigned this Nov 14, 2017
@addaleax
Copy link
Member

Landed in 66e2751

@addaleax addaleax closed this Nov 18, 2017
addaleax pushed a commit that referenced this pull request Nov 18, 2017
@refack @addaleax
tools: bump remark-cli to 4.0
66e2751 
PR-URL: #17028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@refack @MylesBorins
tools: bump remark-cli to 4.0
16f181e 
PR-URL: #17028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@gibfahn
Copy link
Member

gibfahn commented Dec 19, 2017

Leaving to bake until remark-cli is stable on master, and these can all be backported together to v8.x

@gibfahn gibfahn added the baking-for-lts PRs that need to wait before landing in a LTS release. label Dec 19, 2017
@MylesBorins MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@refack @MylesBorins
tools: bump remark-cli to 4.0
7d4d96b 
PR-URL: #17028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
@refack refack deleted the bump-remark-to-4 branch September 5, 2018 22:29
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@refack @addaleax @gibfahn @jasnell @watilde @cjihrig @MylesBorins @nodejs-github-bot