Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix SetClientCertEngine() nullptr dereference #16965

Merged
merged 1 commit into from
Nov 15, 2017
Merged

src: fix SetClientCertEngine() nullptr dereference #16965

merged 1 commit into from
Nov 15, 2017

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Nov 12, 2017 •
edited
Loading

Introduced in commit 6ee985f ("tls: implement clientCertEngine
option") which was merged yesterday.

CI: https://ci.nodejs.org/job/node-test-pull-request/11376/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Nov 12, 2017
@bnoordhuis bnoordhuis mentioned this pull request Nov 12, 2017
Closed
4 tasks
@bnoordhuis bnoordhuis mentioned this pull request Nov 12, 2017
Closed
4 tasks
@bnoordhuis
src: fix SetClientCertEngine() nullptr dereference
6c76140 
Introduced in commit 6ee985f ("tls: implement clientCertEngine
option") which was merged November 11.

PR-URL: nodejs#16965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis closed this Nov 15, 2017
@bnoordhuis bnoordhuis deleted the fix-nullptr-deref branch November 15, 2017 11:16
@bnoordhuis bnoordhuis merged commit 6c76140 into nodejs:master Nov 15, 2017
@bnoordhuis
Copy link
Member Author

Landed in 6c76140.

MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
@bnoordhuis @MylesBorins
src: fix SetClientCertEngine() nullptr dereference
7ac760b 
Introduced in commit 6ee985f ("tls: implement clientCertEngine
option") which was merged November 11.

PR-URL: #16965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@gibfahn
Copy link
Member

gibfahn commented Dec 19, 2017

Depends on #14903, which is semver-minor

@jasnell
Copy link
Member

jasnell commented Aug 17, 2018

Can only be backported if #14903 is backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bnoordhuis @gibfahn @jasnell @fhinkel @cjihrig @MylesBorins @BethGriggs @nodejs-github-bot