errors: consistent format for error messages #16904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently use printf-style strings for error messages that do not need a custom argument order or processing of arguments.
apapirovski
added
the
errors
maclover7
reviewed
Nov 9, 2017
| create: function(context) { | ||
| return { | ||
| ExpressionStatement: function(node) { | ||
| if (!isDefiningError(node)) |
There was a problem hiding this comment.
I've been meaning to do this, but while you're here, can you extract this to rules-utils.js, and update the other usage of this?
|
@maclover7 Yeah, I'm fine with either. We currently have more printf-formatted errors so this made sense to me (and the fact that it avoids creating all these extra functions) but either is fine. |
jasnell
approved these changes
Nov 10, 2017
addaleax
approved these changes
Nov 18, 2017
|
Landed in 4b82d89 |
addaleax
pushed a commit
that referenced
this pull request
Nov 18, 2017
Consistently use printf-style strings for error messages that do not need a custom argument order or processing of arguments. PR-URL: #16904 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Should this be backported to |
apapirovski
added a commit
to apapirovski/node
that referenced
this pull request
Dec 11, 2017
Consistently use printf-style strings for error messages that do not need a custom argument order or processing of arguments. PR-URL: nodejs#16904 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
|
Backport in #17624 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Consistently use printf-style strings for error messages that do not need a custom argument order or processing of arguments. Backport-PR-URL: #17624 PR-URL: #16904 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Consistently use printf-style strings for error messages that do not need a custom argument order or processing of arguments. Backport-PR-URL: #17624 PR-URL: #16904 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Consistently use printf-style strings for error messages that do not need a custom argument order or processing of arguments. Backport-PR-URL: #17624 PR-URL: #16904 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
|
Should this be backported to v6.x and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently use printf-style strings for error messages that do not need a custom argument order or processing of arguments.
Also added an eslint rule (with a test) that checks for this and warns about it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors, test, tools