Test repl reset event #16836
Test repl reset event #16836
Conversation
|
I'm not super sure about the wording so any feedback welcome |
| @@ -61,7 +64,8 @@ function testResetGlobal() { | |||
| assert.strictEqual( | |||
| context.foo, | |||
| 42, | |||
| '"foo" property is missing from REPL using global as context' | |||
| '"foo" property is different from REPL using global as context.' + | |||
There was a problem hiding this comment.
Nit: Probably should be a space at the end of the string on this line or else a space at the beginning of the string on the next line? Same for two other instances above.
There was a problem hiding this comment.
Good point, tell me what'd prefer :P
There was a problem hiding this comment.
@AdriVanHoudt I think we prefer @Trott's suggested style for most of the codebase :)
There was a problem hiding this comment.
@AdriVanHoudt Space at the end is more typical throughout the code base as far as I've noticed, so go with that I guess? But either would be fine.
|
@Trott I added a space at the end of every line, let me know if I need to squash this |
|
The space made line 47 to long 🤦♂️ |
😃 If you could wrap and fix, that would be great. (And if not, someone else like me can come along and do it when we're ready to land. But saving that person a few keystrokes and some time would be great.) |
|
Do you mean splitting the string in 3 parts instead of the current 2? I feel like eslint should be able to fix this 🙃 |
Easiest fix is probably to remove the comma after
ESLint docs indicate |
Ok that rule does more than I expected, shortsighted comment from me sorry I updated the line, so let's hope it is good now |
PR-URL: #16836 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in bbcbcb8 Thank you for the contribution @AdriVanHoudt! |
PR-URL: #16836 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16836 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16836 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16836 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16836 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)